[QNN] Add support for per channel weight scale in dense op #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
commented
Feb 14, 2020
masahi
commented
Feb 14, 2020
|
ready to go @vinx13 @FrozenGene |
vinx13
approved these changes
Feb 15, 2020
|
thanks @anijain2305 @FrozenGene @vinx13 |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
* add test case for per channel dense * add unit arg in tflite frontend * update qnn legalize test * fix output dim index
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
* add test case for per channel dense * add unit arg in tflite frontend * update qnn legalize test * fix output dim index
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
* add test case for per channel dense * add unit arg in tflite frontend * update qnn legalize test * fix output dim index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QNN dense op does not accept a vector weight scale as argument at the moment, but this restriction can be fixed trivially.
please review @anijain2305 @vinx13 @FrozenGene