Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPI][Relay] Add bitwise ops #4815

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Conversation

abergeron
Copy link
Contributor

We found we have a need for bitwise ops in certain cases (mostly for implementing random number generators on the GPU), so I've added them.

There are no tests for relay because there did not seems to be any tests for the logical_ versions, outside of the the tensorflow frontend.

@jroesch
Copy link
Member

jroesch commented Feb 5, 2020

cc @jwfromm can you review this?

Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean implementation, LGTM!

@tqchen tqchen merged commit 2bd2f99 into apache:master Feb 6, 2020
@tqchen
Copy link
Member

tqchen commented Feb 6, 2020

Thanks @jroesch @jwfromm @abergeron !

anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Feb 10, 2020
* Add bitwise ops to topi

* Add the bitwise ops to relay.
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
* Add bitwise ops to topi

* Add the bitwise ops to relay.
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
* Add bitwise ops to topi

* Add the bitwise ops to relay.
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
* Add bitwise ops to topi

* Add the bitwise ops to relay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants