Fix compilaton of bfloat16 on Windows #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hcho3 would you mind share what was the error you see? just wondering whether it is related to what bothers me recently. |
tqchen
approved these changes
Nov 24, 2019
|
@yzhliu Here is the compilation error: 3>C:\Users\Administrator\Desktop\NeoLenovoPOCTVMFork\3rdparty\bfloat16\bfloat16.cc(63,60): error C2491: 'FloatToBFloat16_wrapper': definition of dllimport function not allowed |
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Nov 26, 2019
yongwww
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__declspec(dllexport)should not be part of a function definition. So moveTVM_DLLmacro to function declaration instead.