[License] move cma_api to 3rdparty. separate BSD 2-clause and 3-clause #4410
Conversation
LICENSE
Outdated
| @@ -214,18 +214,22 @@ Apache Software Foundation License 2.0 | |||
| 3rdparty/dmlc-core | |||
|
|
|||
|
|
|||
| BSD License | |||
| BSD 2-clause License | |||
| ----------- | |||
There was a problem hiding this comment.
make sure the underscore covers all the above line
|
|
||
| BSD 3-clause License | ||
| ----------- | ||
|
|
||
| 3rdparty/dmlc-core/include/dmlc/concurrentqueue.h |
There was a problem hiding this comment.
Add 3rdparty/dmlc-core/include/dmlc/blockingconcurrentqueue.h
c.f. https://github.com/apache/incubator-mxnet/blob/master/LICENSE#L337
There was a problem hiding this comment.
NOTE: we need to add a license file for blockingconcurrentqueue.h, as part of the file is under zlib, and others under BSD-2
There was a problem hiding this comment.
We should have a section
BSD 2-clause license + zlib license
LICENSE
Outdated
| ----------- | ||
|
|
||
| 3rdparty/picojson | ||
|
|
||
|
|
||
| BSD 3-clause License |
There was a problem hiding this comment.
Sorry I double checked, and find that the concurrentqueue.h is under BSD-2 (instead of 3)
|
@tqchen please double check. |
|
Thanks @yzhliu I will send a followup PR to refine the blockingconcurrentqueue license |
apache#4410) * [License] move cma_api to 3rdparty. separate BSD 2-clause and 3-clause * add zlib license for blockingconcurrentqueue.h
apache#4410) * [License] move cma_api to 3rdparty. separate BSD 2-clause and 3-clause * add zlib license for blockingconcurrentqueue.h
apache#4410) * [License] move cma_api to 3rdparty. separate BSD 2-clause and 3-clause * add zlib license for blockingconcurrentqueue.h
@tqchen @tmoreau89