Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require LLVM >= 9 for AMDGPU backend #4253

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Require LLVM >= 9 for AMDGPU backend #4253

merged 1 commit into from
Nov 5, 2019

Conversation

t-vi
Copy link
Contributor

@t-vi t-vi commented Nov 5, 2019

LLVM 8 will crash when loading the bitcodes

This is a runtime check as the file will be compiled in even when
USE_ROCM OFF is used in the configuration if ROCM is installed
in the default location.

Fixes: #4087

@t-vi
Require LLVM >= 9 for AMDGPU backend
05f8e3c 
LLVM 8 will crash when loading the bitcodes

This is a runtime check as the file will be compiled in even when
USE_ROCM OFF is used in the configuration if ROCM is installed
in the default location.

Fixes: apache#4087
@t-vi
Copy link
Contributor Author

t-vi commented Nov 5, 2019

@masahi @petrex @tqchen for interest in the issue and potential reviewers.

@masahi masahi merged commit 635831c into apache:master Nov 5, 2019
zxy844288792 pushed a commit to neo-ai/tvm that referenced this pull request Nov 13, 2019
@t-vi
Require LLVM >= 9 for AMDGPU backend (apache#4253)
3a534bd 
LLVM 8 will crash when loading the bitcodes

This is a runtime check as the file will be compiled in even when
USE_ROCM OFF is used in the configuration if ROCM is installed
in the default location.

Fixes: apache#4087
@yzhliu yzhliu mentioned this pull request Nov 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masahi masahi masahi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rocm backend: crash with LLVM 8
2 participants
@t-vi @masahi