[ARITH] Fix lowering of FloorMod #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Oct 31, 2019
| @@ -136,8 +136,7 @@ class IntrinInjecter : public arith::IRMutatorWithAnalyzer { | |||
|
|
|||
| if (analyzer_->CanProveGreaterEqual(op->b, 0)) { | |||
| // Common pass, positive divisor | |||
| if (analyzer_->CanProveGreaterEqual(op->a, 0) || | |||
| analyzer_->CanProveGreaterEqual(e, 0)) { | |||
There was a problem hiding this comment.
We want to keep the condition of e>=0, as it can sometimes imply a>=0 but we cannot directly prove it
There was a problem hiding this comment.
But floordiv(a, b) = e >= 0 always holds at this point (because b >= 0, and floordiv is always non-negative in this case).
There was a problem hiding this comment.
not really, unless you meant floormod
There was a problem hiding this comment.
Sorry, I indeed meant floordmod (and we are in the FloorMod function).
tqchen
approved these changes
Nov 1, 2019
|
Thanks @sgrechanik-h ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.