Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTA][TSIM] Serial GEMM Application Added #4082

Merged
merged 9 commits into from
Oct 10, 2019
Merged

[VTA][TSIM] Serial GEMM Application Added #4082

merged 9 commits into from
Oct 10, 2019

Conversation

BenjaminTu
Copy link
Contributor

Added a more complex TSIM application that performs bit serial computation on GEMM, serves as an advance reference other than tsim_example for people who want to utilize TSIM for a more complicated design.

@tmoreau89
Copy link
Contributor

Thanks for the PR @BenjaminTu! Can we rename the app to something different than serialLoadMM? Perhaps something simpler, like gemm or matrixmult? I think we'll need to explain that as part of the parameterization space, we can obtain serial multiplication using narrow multiply and shift-accumulates.

@BenjaminTu
Copy link
Contributor Author

@tmoreau89 I've change the application name to gemm, and added some information on bit serial computation on GEMM. Let me know if more information is needed

@tmoreau89
Copy link
Contributor

@BenjaminTu thank you for addressing the changes. One high level question I have is: should we consider re-using sources between the apps, and also with the VTA chisel sources? For instance, can we re-use GEMM modules between this example and VTA's implementation? This would ensure that we can perform more fine-grained unit tests in the future.

@tmoreau89
Copy link
Contributor

I'm gonna approve and merge, and discuss refactor in a subsequent PR. Thanks @BenjaminTu for the contribution

@tmoreau89 tmoreau89 merged commit 47e50e1 into apache:master Oct 10, 2019
anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Oct 17, 2019
* app init push

* fix on readme

* change name, add bit serial explanantion

* rm serialLoadMM, change doc

* syntax change for readme

* add parallel test functionality

* fix readme

* add python doc

* syntax
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 18, 2019
* app init push

* fix on readme

* change name, add bit serial explanantion

* rm serialLoadMM, change doc

* syntax change for readme

* add parallel test functionality

* fix readme

* add python doc

* syntax
tqchen pushed a commit to tqchen/tvm that referenced this pull request Mar 29, 2020
* app init push

* fix on readme

* change name, add bit serial explanantion

* rm serialLoadMM, change doc

* syntax change for readme

* add parallel test functionality

* fix readme

* add python doc

* syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants