-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VTA][TSIM] Serial GEMM Application Added #4082
Conversation
Thanks for the PR @BenjaminTu! Can we rename the app to something different than |
@tmoreau89 I've change the application name to gemm, and added some information on bit serial computation on GEMM. Let me know if more information is needed |
vta/apps/gemm/hardware/chisel/src/main/scala/accel/Compute.scala
Outdated
Show resolved
Hide resolved
@BenjaminTu thank you for addressing the changes. One high level question I have is: should we consider re-using sources between the apps, and also with the VTA chisel sources? For instance, can we re-use GEMM modules between this example and VTA's implementation? This would ensure that we can perform more fine-grained unit tests in the future. |
I'm gonna approve and merge, and discuss refactor in a subsequent PR. Thanks @BenjaminTu for the contribution |
* app init push * fix on readme * change name, add bit serial explanantion * rm serialLoadMM, change doc * syntax change for readme * add parallel test functionality * fix readme * add python doc * syntax
* app init push * fix on readme * change name, add bit serial explanantion * rm serialLoadMM, change doc * syntax change for readme * add parallel test functionality * fix readme * add python doc * syntax
* app init push * fix on readme * change name, add bit serial explanantion * rm serialLoadMM, change doc * syntax change for readme * add parallel test functionality * fix readme * add python doc * syntax
Added a more complex TSIM application that performs bit serial computation on GEMM, serves as an advance reference other than tsim_example for people who want to utilize TSIM for a more complicated design.