[Relay][VM] Fix constant folding issue in VM compiler #4077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the performance now caused by pass or vm related things, like dispatching and memory allocation? |
wweic
force-pushed
the
vm-compiler
branch
2 times, most recently
from
e622648 to
b11b9d2
Compare
icemelon
reviewed
Oct 7, 2019
Yes. Most of the time spent other than packed function execution are |
1. allow pass params when compile a module 2. enhance profiler robustness
icemelon
reviewed
Oct 8, 2019
icemelon
reviewed
Oct 8, 2019
wweic
force-pushed
the
vm-compiler
branch
3 times, most recently
from
8af82d3 to
9543ede
Compare
icemelon
reviewed
Oct 9, 2019
icemelon
requested changes
Oct 9, 2019
icemelon
requested changes
Oct 9, 2019
icemelon
approved these changes
Oct 9, 2019
anijain2305
pushed a commit
to anijain2305/tvm
that referenced
this pull request
Oct 17, 2019
* [Relay][VM] Fix constant folding issue in VM compiler 1. allow pass params when compile a module 2. enhance profiler robustness * remove dead code * fix lint * add get_params * fix test * don't pass params back * remove get_params * docs * move compile function to api * compile clashes with builtin name * fix compilation error * remove dead code
wweic
added a commit
to neo-ai/tvm
that referenced
this pull request
Oct 18, 2019
* [Relay][VM] Fix constant folding issue in VM compiler 1. allow pass params when compile a module 2. enhance profiler robustness * remove dead code * fix lint * add get_params * fix test * don't pass params back * remove get_params * docs * move compile function to api * compile clashes with builtin name * fix compilation error * remove dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up mxnet resnset18 by 4x because it fixes constant folding. Now vm is just
1.4x slower than relay graph runtime.
cc @jroesch @zhiics @icemelon9