[RELAY]impose a max op limit to the op fusion pass #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Sep 25, 2019
src/relay/pass/fuse_ops.cc
Outdated
| /*! | ||
| * \brief The number of nodes belonging to this group | ||
| */ | ||
| uint num_nodes{1}; |
There was a problem hiding this comment.
uint is not really a cross platform data type, use uint32_t or uint64_t
|
LGTM, we should consider a more intelligent strategy for controlling how much fusion happens, right now the Relay fusion algorithm is greedy wrt to fusion. cc @jwfromm |
icemelon
approved these changes
Sep 25, 2019
tqchen
approved these changes
Sep 25, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
* impose a max op limit to op fusion * use cross platform data type
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
* impose a max op limit to op fusion * use cross platform data type
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 1, 2019
* impose a max op limit to op fusion * use cross platform data type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.
ATT. The compilation may overflow the stack during lowering when a fused op contains a huge statement. @icemelon9