Adding support to check if an attribute is present or not without having to get the value #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to get the value.
|
@zhiics @vinx13 @anijain2305 Can you please review? |
vinx13
reviewed
Sep 17, 2019
python/tvm/relay/frontend/common.py
Outdated
| @@ -41,6 +41,20 @@ class StrAttrsDict(object): | |||
| def __init__(self, attrs): | |||
| self.attrs = attrs | |||
|
|
|||
| def is_attr_present(self, key): | |||
There was a problem hiding this comment.
let's think about the name, shall we just name it has_attr?
There was a problem hiding this comment.
I don't have a problem with has_attr. i can submit a change with that name.
|
@vinx13 can you take a look at it now. |
vinx13
approved these changes
Sep 17, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
…ing to get the value (apache#3957) * Adding support to check if an attribute is present or not without having to get the value. * - Renaming the method to more appropriate name.
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
…ing to get the value (apache#3957) * Adding support to check if an attribute is present or not without having to get the value. * - Renaming the method to more appropriate name.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 1, 2019
…ing to get the value (apache#3957) * Adding support to check if an attribute is present or not without having to get the value. * - Renaming the method to more appropriate name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a requirement in the parsing of pre-quantized mxnet model where; an attribute's value depends on another attribute being present or absent. The example can be found here
Since there is no way for querying if an attribute is present or not in a very clean way possible I am adding a new method to check if an attribute is present.
Since the attribute in question is a float passing in a NAN or something equivalent is not right since i NAN could be a legal value of something gone wrong during quantization.
Another way could be to pass a String instead as a default value, but that will not be a clean solution since we have a api which is supposed to return a float is returning a string instead.