[tvm][codegen] Make buffer auto broadcast independent to the order of input args #3956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently auto_broadcast of buffer may cause a problem when it hoists the
if
guard, as the lifted expression may use the arg before it is defined through let binding.For example, the following code will cause problems during codege, because we will have something like
if (o1/x == 1) ...
becauseo1
andx
are bound.This fix hoist the let binding before the uses of the assert/if statements.
Another problem we might need to solve is the the current input arg can only be a single variable instead of an expression, i.e.
A = tvm.placeholder((m/x, n), name='A')
would fail, @yzhliu has also observed this. We can probably solve this in a follow-up PR. This PR will feed all these args directly in the build statement so that they can be correctly bound.CC @yzhliu, @icemelon9, @tqchen