Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TENSORFLOW] Convert scalar Const into tvm.relay.const #3885

Merged
merged 2 commits into from
Sep 4, 2019
Merged

[TENSORFLOW] Convert scalar Const into tvm.relay.const #3885

merged 2 commits into from
Sep 4, 2019

Conversation

lixiaoquan
Copy link
Contributor

No description provided.

zhiics
zhiics reviewed Sep 3, 2019
View reviewed changes
Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Can we also use these function for other places in the file, i.e. _clip_by_value and _crop_and_resize?

@lixiaoquan
Copy link
Contributor Author

I've updated to use these functions to replace params.get()

zhiics
zhiics approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@zhiics zhiics merged commit df7cc5d into apache:master Sep 4, 2019
MarisaKirisame pushed a commit to MarisaKirisame/tvm that referenced this pull request Sep 7, 2019
@lixiaoquan @MarisaKirisame
[TENSORFLOW] Convert scalar Const into tvm.relay.const (apache#3885)
aa416cf 
* [TENSORFLOW] Convert scalar Const into tvm.relay.const

* use _get_num_param() and _get_list_param()
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
@lixiaoquan @wweic
[TENSORFLOW] Convert scalar Const into tvm.relay.const (apache#3885)
dc3af7f 
* [TENSORFLOW] Convert scalar Const into tvm.relay.const

* use _get_num_param() and _get_list_param()
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
@lixiaoquan @wweic
[TENSORFLOW] Convert scalar Const into tvm.relay.const (apache#3885)
4b516d1 
* [TENSORFLOW] Convert scalar Const into tvm.relay.const

* use _get_num_param() and _get_list_param()
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 16, 2019
@lixiaoquan @wweic
[TENSORFLOW] Convert scalar Const into tvm.relay.const (apache#3885)
3f9e6da 
* [TENSORFLOW] Convert scalar Const into tvm.relay.const

* use _get_num_param() and _get_list_param()
@tqchen tqchen mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiics zhiics zhiics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lixiaoquan @zhiics