[VTA] Fix TSIM compile error in Linux (add missing -fPIC flag) #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaluisjose
approved these changes
Sep 2, 2019
|
Thanks for the fixes @liangfu ! |
tmoreau89
requested changes
Sep 2, 2019
|
I've left a comment to fix indentation/tabs; otherwise it all looks good! |
tmoreau89
approved these changes
Sep 3, 2019
MarisaKirisame
pushed a commit
to MarisaKirisame/tvm
that referenced
this pull request
Sep 7, 2019
…e#3876) * [VTA] Fix TSIM compile error in Linux (add missing -fPIC flag); * [VTA] Fix TSIM compile error in Linux (add missing -fPIC flag); * fix indentation problem;
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
…e#3876) * [VTA] Fix TSIM compile error in Linux (add missing -fPIC flag); * [VTA] Fix TSIM compile error in Linux (add missing -fPIC flag); * fix indentation problem;
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
…e#3876) * [VTA] Fix TSIM compile error in Linux (add missing -fPIC flag); * [VTA] Fix TSIM compile error in Linux (add missing -fPIC flag); * fix indentation problem;
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 16, 2019
…e#3876) * [VTA] Fix TSIM compile error in Linux (add missing -fPIC flag); * [VTA] Fix TSIM compile error in Linux (add missing -fPIC flag); * fix indentation problem;
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Mar 29, 2020
…e#3876) * [VTA] Fix TSIM compile error in Linux (add missing -fPIC flag); * [VTA] Fix TSIM compile error in Linux (add missing -fPIC flag); * fix indentation problem;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the compilation issue raised in #3797 , which requires running
makecommand twice to compile the generated .cpp files into the shared library. In addition, the missing-fPICflag has also been added for fixing the compile error in Linux;@vegaluisjose Please review.