Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTA] [Chisel] Bug fix for VME Shell #3737

Merged
merged 2 commits into from
Aug 8, 2019
Merged

[VTA] [Chisel] Bug fix for VME Shell #3737

merged 2 commits into from
Aug 8, 2019

Conversation

BenjaminTu
Copy link
Contributor

Bug fix for ready signal is only high for 1 cycle when sending data where len==0. (corner case)

Copy link
Member

@vegaluisjose vegaluisjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @BenjaminTu !

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmoreau89 tmoreau89 merged commit d76612d into apache:master Aug 8, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Aug 9, 2019
@BenjaminTu BenjaminTu deleted the vmefix branch August 12, 2019 17:52
anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Aug 22, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
tqchen pushed a commit to tqchen/tvm that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants