Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPI][FIX] Typo in schedule template for conv2d_direct (#3648) #3717

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

mingwayzhang
Copy link
Contributor

* Fix the tile_rx and tile_ry issue.

Note that this patch depends on pull request #9 in tvm-distro.

Please review. Thanks.

    * Fix the tile_rx and tile_ry issue.

    Note that this patch depends on pull request apache#9 in tvm-distro.
@mingwayzhang mingwayzhang changed the title Fix (2/2) [TOPI] conv2d schedule code (#3648) [TOPI] conv2d schedule code (#3648) Aug 6, 2019
Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the cuda TOPHUB version is also proposed in #3606

I suggest you revert the tophub changes, and keep the changes local to the conv2d_direct.py file, and change the title labels to [TOPI][FIX] Typo in schedule template for conv2d_direct

@tmoreau89
Copy link
Contributor

@cbalint13 you are also proposing a version change on CUDA tophub schedule; can you coordinate to serialize the changes?

@mingwayzhang mingwayzhang changed the title [TOPI] conv2d schedule code (#3648) [TOPI][FIX] Typo in schedule template for conv2d_direct (#3648) Aug 6, 2019
@cbalint13
Copy link
Contributor

@cbalint13 you are also proposing a version change on CUDA tophub schedule; can you coordinate to serialize the changes?

  • Will rebase everything once this very 3717 is merged.
    So please merge this first, I have more work pending on our side (even beyond the simple tophub update).

Thank you !

@mingwayzhang
Copy link
Contributor Author

Changing the cuda TOPHUB version is also proposed in #3606

I suggest you revert the tophub changes, and keep the changes local to the conv2d_direct.py file, and change the title labels to [TOPI][FIX] Typo in schedule template for conv2d_direct

Are you suggesting that the schedule function schedule_conv2d_nchw in conv2d_direct.py using the wrong schedule config? From my understanding, all schedule configs with name top_nn_conv2d are consumed by schedul_conv2d_nchw.

@tmoreau89
Copy link
Contributor

Thank you for the clarifications

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmoreau89 tmoreau89 merged commit 831b32e into apache:master Aug 6, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Aug 9, 2019
* Fix the tile_rx and tile_ry issue.

    Note that this patch depends on pull request apache#9 in tvm-distro.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
* Fix the tile_rx and tile_ry issue.

    Note that this patch depends on pull request #9 in tvm-distro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants