-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOPI][FIX] Typo in schedule template for conv2d_direct (#3648) #3717
Conversation
mingwayzhang
commented
Aug 6, 2019
* Fix the tile_rx and tile_ry issue. Note that this patch depends on pull request apache#9 in tvm-distro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the cuda TOPHUB version is also proposed in #3606
I suggest you revert the tophub changes, and keep the changes local to the conv2d_direct.py
file, and change the title labels to [TOPI][FIX] Typo in schedule template for conv2d_direct
@cbalint13 you are also proposing a version change on CUDA tophub schedule; can you coordinate to serialize the changes? |
Thank you ! |
Are you suggesting that the schedule function |
Thank you for the clarifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix the tile_rx and tile_ry issue. Note that this patch depends on pull request apache#9 in tvm-distro.
* Fix the tile_rx and tile_ry issue. Note that this patch depends on pull request #9 in tvm-distro.