[DOC] Update ssd doc to avoid confusion. #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhliu
reviewed
Jul 31, 2019
| # change target argument to 'opencl -device=intel_graphics' | ||
| # To get best inference performance on Intel graphics, | ||
| # change target argument to :code:`opencl -device=intel_graphics`, | ||
| # except for Mac, target needs to be set to `opencl` only. |
There was a problem hiding this comment.
not sure whether it is clear for native speaker ... "except for Mac, target needs to be set to opencl only." means set "opencl" for mac, or for non-mac?
shall we also mention intel extension on mac?
There was a problem hiding this comment.
Updated, lemme know how it looks now.
yzhliu
approved these changes
Jul 31, 2019
|
Thanks! |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
* intel graphics conv2d bugs fixed for inception_v3 * intel conv2d api updated, nn input size 4 condition added * review addressed * move conv_tags to attributes * ssd doc updated * address comment
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
* intel graphics conv2d bugs fixed for inception_v3 * intel conv2d api updated, nn input size 4 condition added * review addressed * move conv_tags to attributes * ssd doc updated * address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yzhliu Could you review?