[Relay][Keras] Dot #3668
[Relay][Keras] Dot #3668
Conversation
python/tvm/relay/frontend/keras.py
Outdated
| inexpr[1] = _op.transpose(inexpr[1], axes=[0, 2, 1]) | ||
| else: | ||
| raise tvm.error.OpAttributeUnimplemented( | ||
| 'Dot with {} is not supported.'.format(keras_layer.axes)) |
There was a problem hiding this comment.
How about the following?
axes=[axes,axes]whenaxesis an integer.- raise an error when axes[i] is neither 1 nor 2.
- transpose inexpr[i] when axes[i] is 1.
This can also handle axes=[1,1] and raise an error against axes=0 or axes=3.
There was a problem hiding this comment.
@kazum thanks, I like the idea!
python/tvm/relay/frontend/keras.py
Outdated
| else: | ||
| raise tvm.error.OpAttributeUnimplemented( | ||
| 'Dot with {} is not supported.'.format(keras_layer.axes)) | ||
| ret = _op.nn.batch_matmul(ret, inexpr[1]) |
There was a problem hiding this comment.
This code works only when the dimension of the input tensor is 3. Pleas add the check.
kazum
added
status: need update
yongwww
force-pushed
the
tensordot
branch
2 times, most recently
from
a305140 to
05fcb90
Compare
|
@kazum just updated the pr, thanks a lot for your comment! |
python/tvm/relay/frontend/keras.py
Outdated
| @@ -461,6 +479,8 @@ def _convert_concat(inexpr, keras_layer, _): | |||
|
|
|||
| def _convert_reshape(inexpr, keras_layer, _): | |||
| _check_data_format(keras_layer) | |||
| if len(keras_layer.target_shape) < 3: | |||
| return _op.reshape(inexpr, newshape=(1, ) + keras_layer.target_shape) | |||
There was a problem hiding this comment.
Can you add a test where this change is necessary?
| data_1 = keras.layers.Input(shape=(32, 32, 3)) | ||
| data_2 = keras.layers.Input(shape=(32, 32)) | ||
| x_1 = keras.layers.Reshape(target_shape=(32, 32, 3))(data_1) | ||
| x_2 = keras.layers.Reshape(target_shape=(32, 32))(data_2) |
There was a problem hiding this comment.
This test cannot be passed for shape (32, 3)?
It looks like changing reshape is unnecessary to support dot. How about removing the change from this pr?
There was a problem hiding this comment.
yeah, it is not related to dot, it's a bug for reshape. Sure, let me remove it
* [Relay][Keras] Dot * fix reshape * fix comments
* [Relay][Keras] Dot * fix reshape * fix comments
* [Relay][Keras] Dot * fix reshape * fix comments
@Huyuwei