tvm/contrib/rocm: improve finding of ld.lld #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refines the detection of ld.lld matching the neighbouring clang file. This is particularly helpful on Ubuntu/Debian when either the default ld.lld is not installed or the versioned one is preferable for consistency. @tqchen I think you last touched the clang equivalent in apache#3590 .
|
yeah I'm aware of this issue but didn't bother to fix. Instead we ask people to just add a symlink :) |
masahi
approved these changes
Jul 30, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
This refines the detection of ld.lld matching the neighbouring clang file. This is particularly helpful on Ubuntu/Debian when either the default ld.lld is not installed or the versioned one is preferable for consistency. @tqchen I think you last touched the clang equivalent in apache#3590 .
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
This refines the detection of ld.lld matching the neighbouring clang file. This is particularly helpful on Ubuntu/Debian when either the default ld.lld is not installed or the versioned one is preferable for consistency. @tqchen I think you last touched the clang equivalent in apache#3590 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refines the detection of ld.lld matching the neighbouring clang
file. This is particularly helpful on Ubuntu/Debian when either the
default ld.lld is not installed or the versioned one is preferable for
consistency.
@tqchen I think you last touched the clang equivalent in #3590 .