Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the x86 auto-tune tutorial #3609

Merged
merged 1 commit into from
Jul 27, 2019

Conversation

peterjc123
Copy link
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

Previously, data was directly used as an input name for the graph. For new users, they may be confused since data also sounds like a constant property name. This PR tries to extract it out and make a variable so that it will be clear for the user if they want to auto-tune their own graph.

@peterjc123
Copy link
Contributor Author

@peterjc123
Copy link
Contributor Author

Copy link
Member

@yzhliu yzhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does ci fail though ...

@peterjc123
Copy link
Contributor Author

I rebased the PR, but it still can't pass CI. After reading the log, I don't think this PR has anything to do with that build error.

@kevinthesun
Copy link
Contributor

No space left on device
Looks like an ci issue.

@yzhliu
Copy link
Member

yzhliu commented Jul 26, 2019

@tqchen Could you look into that?

@tqchen
Copy link
Member

tqchen commented Jul 26, 2019

The space issue should have been fixed

@peterjc123
Copy link
Contributor Author

This CI build passes this time.

@kevinthesun kevinthesun merged commit 18d0ad3 into apache:master Jul 27, 2019
@kevinthesun
Copy link
Contributor

Thanks!

@peterjc123 peterjc123 deleted the tutorial_fix branch July 27, 2019 17:38
wweic pushed a commit to wweic/tvm that referenced this pull request Aug 9, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants