-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VTA] [Chisel] support for different inp/wgt bits, rewrote DotProduct for clarity #3605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first contribution Ben, let's start iterating on the code.
Also, now that we are doing this. I am thinking we can update the name of the |
Thanks @BenjaminTu for this PR! This is looking good |
Question: do we want to only implement addition tree, or have an FIR style chain of adders as another option; I believe that the latter is more DSP slice friendly, and easier to place and route due to its regular pattern. However only FPGA synthesis, placement and route will actually tell; it might be a good experiment to try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vegaluisjose I notice a certain spacing style that looks like I think that we should perhaps discuss a plan to put a scala lint test in place to avoid to have to do too many style edits in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vegaluisjose I notice a certain spacing style that looks like
a*b + c
, and should instead look likea * b + c
as per: https://docs.scala-lang.org/style/method-invocation.html#symbolic-methodsoperatorsI think that we should perhaps discuss a plan to put a scala lint test in place to avoid to have to do too many style edits in the future.
Yeah I like the idea and we should start working on that.
We can have both or more, this is one of the advantage of the language. However, in terms of the FIR style chain we would have to make a compromise, because right now we are assuming that the This was actually how I started the design. The |
… for clarity (apache#3605) * support for different inp/wgt bits, rewrote dot for clarity * [VTA] [Chisel] support for different inp/wgt bits, rewrote DotProduct for clarity * [VTA] [Chisel] support for different inp/wgt bits, rewrote DotProduct for clarity * change back to sim * fix index * fix index * fix indent * fix indent * fix indent * fix trailing spaces * fix trailing spaces * change to more descriptive name * matric->matrix * fix spacing * fix spacing & added generic name for dot * better parameter flow * spacing * spacing * spacing * update requirement (tested) for dot, spacing * function call convention * small edit
… for clarity (apache#3605) * support for different inp/wgt bits, rewrote dot for clarity * [VTA] [Chisel] support for different inp/wgt bits, rewrote DotProduct for clarity * [VTA] [Chisel] support for different inp/wgt bits, rewrote DotProduct for clarity * change back to sim * fix index * fix index * fix indent * fix indent * fix indent * fix trailing spaces * fix trailing spaces * change to more descriptive name * matric->matrix * fix spacing * fix spacing & added generic name for dot * better parameter flow * spacing * spacing * spacing * update requirement (tested) for dot, spacing * function call convention * small edit
… for clarity (apache#3605) * support for different inp/wgt bits, rewrote dot for clarity * [VTA] [Chisel] support for different inp/wgt bits, rewrote DotProduct for clarity * [VTA] [Chisel] support for different inp/wgt bits, rewrote DotProduct for clarity * change back to sim * fix index * fix index * fix indent * fix indent * fix indent * fix trailing spaces * fix trailing spaces * change to more descriptive name * matric->matrix * fix spacing * fix spacing & added generic name for dot * better parameter flow * spacing * spacing * spacing * update requirement (tested) for dot, spacing * function call convention * small edit
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.