Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional architectures beyond x86_64 in ubuntu_install_java #3546

Merged
merged 2 commits into from
Jul 18, 2019

Conversation

u99127
Copy link
Contributor

@u99127 u99127 commented Jul 15, 2019

While attempting to get a development environment going for TVM on my AArch64 desktop, I ran into some hardcoding of architecture tags.

Fixed thusly and allows me to move on to my next issue.

Ok ?

regards
Ramana

While attempting to get a development environment going for TVM
on my AArch64 desktop I ran into some hardcoding of relevant architectures.

Fixed thusly and allows me to move on to my next step.

Ok ?

regards
Ramana
Copy link
Contributor

@mshawcroft mshawcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit picks inline...

docker/install/ubuntu_install_java.sh Outdated Show resolved Hide resolved
docker/install/ubuntu_install_java.sh Outdated Show resolved Hide resolved
docker/install/ubuntu_install_java.sh Outdated Show resolved Hide resolved
docker/install/ubuntu_install_java.sh Outdated Show resolved Hide resolved
@kevinthesun kevinthesun added the status: need update need update based on feedbacks label Jul 16, 2019
@tqchen
Copy link
Member

tqchen commented Jul 17, 2019

Copy link
Contributor

@mshawcroft mshawcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen tqchen merged commit e686da7 into apache:master Jul 18, 2019
@tqchen tqchen added status: accepted and removed status: need update need update based on feedbacks labels Jul 18, 2019
@tqchen
Copy link
Member

tqchen commented Jul 18, 2019

Thanks @u99127 @mshawcroft , this PR is now merged

@u99127 u99127 deleted the fix-java-arch-hardcoding branch July 20, 2019 12:42
wweic pushed a commit to wweic/tvm that referenced this pull request Aug 9, 2019
…apache#3546)

* Support additional architectures beyond x86_64 in ubuntu_install_java

While attempting to get a development environment going for TVM
on my AArch64 desktop I ran into some hardcoding of relevant architectures.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
…apache#3546)

* Support additional architectures beyond x86_64 in ubuntu_install_java

While attempting to get a development environment going for TVM
on my AArch64 desktop I ran into some hardcoding of relevant architectures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants