-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional architectures beyond x86_64 in ubuntu_install_java #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While attempting to get a development environment going for TVM on my AArch64 desktop I ran into some hardcoding of relevant architectures. Fixed thusly and allows me to move on to my next step. Ok ? regards Ramana
mshawcroft
reviewed
Jul 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit picks inline...
mshawcroft
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tqchen
added
status: accepted
and removed
status: need update
need update based on feedbacks
labels
Jul 18, 2019
Thanks @u99127 @mshawcroft , this PR is now merged |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
…apache#3546) * Support additional architectures beyond x86_64 in ubuntu_install_java While attempting to get a development environment going for TVM on my AArch64 desktop I ran into some hardcoding of relevant architectures.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
…apache#3546) * Support additional architectures beyond x86_64 in ubuntu_install_java While attempting to get a development environment going for TVM on my AArch64 desktop I ran into some hardcoding of relevant architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to get a development environment going for TVM on my AArch64 desktop, I ran into some hardcoding of architecture tags.
Fixed thusly and allows me to move on to my next issue.
Ok ?
regards
Ramana