Relaxing convolution infer checks. #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yzhliu @kevinthesun @tqchen @rankyung-hong Please review. |
anijain2305
force-pushed
the
conv_infer_relax
branch
from
242284b to
03905c0
Compare
yzhliu
approved these changes
Jul 8, 2019
anijain2305
force-pushed
the
conv_infer_relax
branch
from
03905c0 to
7e855f0
Compare
- Weight dtype can be different than idtype. So, using the weight tensor to set the dtype of weight. - For conv2d NCHWc operator, the weight can be of any dimension. For int8 computation on Intel, it can be 7D. Relaxing the weight type checking.
anijain2305
force-pushed
the
conv_infer_relax
branch
from
7e855f0 to
3cb785d
Compare
|
Thanks @anijain2305 ! |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jul 11, 2019
- Weight dtype can be different than idtype. So, using the weight tensor to set the dtype of weight. - For conv2d NCHWc operator, the weight can be of any dimension. For int8 computation on Intel, it can be 7D. Relaxing the weight type checking.
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jul 11, 2019
- Weight dtype can be different than idtype. So, using the weight tensor to set the dtype of weight. - For conv2d NCHWc operator, the weight can be of any dimension. For int8 computation on Intel, it can be 7D. Relaxing the weight type checking.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 11, 2019
- Weight dtype can be different than idtype. So, using the weight tensor to set the dtype of weight. - For conv2d NCHWc operator, the weight can be of any dimension. For int8 computation on Intel, it can be 7D. Relaxing the weight type checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the dtype of weight.
computation on Intel, it can be 7D. Relaxing the weight type checking.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.