Passing dilation argument to account for API change. #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoubhik
reviewed
Jul 8, 2019
| @@ -112,8 +112,8 @@ def run_inference(data_dtype, kernel_dtype, out_dtype, im_height, im_width, in_f | |||
|
|
|||
| with tvm.target.create(TARGET_NAME): | |||
| conv = topi.nn.conv2d_NCHWc(data, kernel, stride=hstride, | |||
| padding=hpad, layout='NCHWc', | |||
| out_layout='NCHWc', out_dtype=out_dtype) | |||
| padding=hpad, dilation=(1, 1), | |||
There was a problem hiding this comment.
is dilation=(1,1) not already a default value in the topi.nn.conv2d_NCHWc API? if not should it be?
There was a problem hiding this comment.
This is a low-level topi operator and not the Relay operator. Relay operator has dilation default arguments which will be passed on to TOPI, if dilation was not provided in the framework graph. So, I think not having a default here is fine.
|
@tqchen The change is in the test case itself. Please let me know if I should add more testing to it. |
tqchen
approved these changes
Jul 9, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jul 11, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jul 11, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.