-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay] Fix reduce axis bug #3422
Conversation
It looks like this change was undone in the past for #2439, but I can't see how |
We need to prevent against the axis being None, it should be |
Not quite sure I understand, unless the existing code was incorrect in keeping
For clarity, this demonstrates the bug this PR fixes:
whereas with the fix:
Otherwise TVM crashes since it expects an array of ints or None, from what I can tell. |
* fix relay reduce axis bug * add tests for reduce bug
* fix relay reduce axis bug * add tests for reduce bug
Fixes failure of
sum
andall
onaxis=0
. Added regression tests as well.