[VTA] Add VTA PYNQ metal_test bitstream program logic and fix compile issue. #3400
Conversation
…compile issue. Issue: VTAProgram not exist and cause compile error. No logic to program the bitstream into FPGA. metal test still use pynq 2.1 library which not support on latest pynq 2.4. Solution: remove old VTAProgram. when setting is pynq, program the bitstream during compile. change DMA link library to libcma.
|
@tmoreau89 could you help to review this patch? |
|
There is currently a big PR (#3135) that will be merged in for VTA (that also affects how the bitstream is programmed). Metal tests are somewhat deprecated and need a rehaul. I will review this patch once the PR is merged in as to make sure that this fix wont' interfere with the changes. |
|
Upon inspection this doesn't look like it will interfere with PR#3135. I'm gonna go ahead with the code review. |
There was a problem hiding this comment.
Overall this looks good, can you please also modify https://github.com/uwsampl/tvm-vta/blob/master/vta/python/vta/exec/rpc_server.py#L58-L59 to use vta_bitstream_program? This way we just need to edit vtaprogram.py if the pynq library API changes.
Also can you rename vtaprogram.py to program_bitstream?
|
@tmoreau89 rpc_server.py change done, vtaprogram.py already get changed int program_bitstream.py? |
|
@tmoreau89 , all review comments already get addressed, change get tested on pynq board and it work good, please kindly let me know if you have any other comments. |
|
Thank you for addressing the comments @huajsj |
… issue. (apache#3400) * [VTA] Add VTA PYNQ metal_test bitstream program logic and fix couple compile issue. Issue: VTAProgram not exist and cause compile error. No logic to program the bitstream into FPGA. metal test still use pynq 2.1 library which not support on latest pynq 2.4. Solution: remove old VTAProgram. when setting is pynq, program the bitstream during compile. change DMA link library to libcma. * Address review commends.
… issue. (apache#3400) * [VTA] Add VTA PYNQ metal_test bitstream program logic and fix couple compile issue. Issue: VTAProgram not exist and cause compile error. No logic to program the bitstream into FPGA. metal test still use pynq 2.1 library which not support on latest pynq 2.4. Solution: remove old VTAProgram. when setting is pynq, program the bitstream during compile. change DMA link library to libcma. * Address review commends.
… issue. (apache#3400) * [VTA] Add VTA PYNQ metal_test bitstream program logic and fix couple compile issue. Issue: VTAProgram not exist and cause compile error. No logic to program the bitstream into FPGA. metal test still use pynq 2.1 library which not support on latest pynq 2.4. Solution: remove old VTAProgram. when setting is pynq, program the bitstream during compile. change DMA link library to libcma. * Address review commends.
Issue:
VTAProgram not exist and cause compile error.
No logic to program the bitstream into FPGA.
metal test still use pynq 2.1 library which not support on latest
pynq 2.4.
Solution:
remove old VTAProgram.
when setting is pynq, program the bitstream during compile.
change DMA link library to libcma.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.