[BUILD] Enable more visible symbols by default #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, I think we should have a release/debug split potentially for devs which flips a bunch of useful debugging flags on by default, changes opt-level, etc. We can do in follow up work. |
jroesch
approved these changes
Jun 13, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a few conversations. Currently, we set
-fvisibility=hiddenby default, this will reduce the number of public symbols and mimic similar behavior as MSVC.However, this also hides many of the names in the stacktrace, making the stacktrace harder to read when an exception happens.
This PR proposes to set that as an option which by default is not switched on. The CI will have one pipeline that switches this option on to allow us to guard against cases that need to have minimum exposure.
cc @jroesch