[relay][frontend] Return module from frontend parsers #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please rebase against the current master |
jroesch
approved these changes
Jun 12, 2019
jroesch
reviewed
Jun 12, 2019
| assert isinstance(expr, Expr) | ||
| self.mod[self.mod.entry_func] = expr | ||
| def _make_executor(self, expr=None): | ||
| expr = expr if expr else self.mod |
There was a problem hiding this comment.
I think we should try to factor all this normalization code into one spot.
There was a problem hiding this comment.
IMO we should only take module and remove expr related code
There was a problem hiding this comment.
I also think we probably only should just take a module, but it looks we need to refactor the interpreter and the graph_runtime somehow.
|
@zhiics please rebase against the latest master |
tqchen
added
status: accepted
and removed
status: need update
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3346
This PR returns
Moduleinstead ofExprfrom the frontend converters because:ModuletoModuleExprcould be error-prone. Or we should really return a function with closures. Returning module should be more convenient.Necessary changes are made in various executors to take both module and expr.
Covered converters:
TensorFlow
TFLite
Keras
Caffe2
MXNet
Darknet
CoreML
ONNX