[RELAY] Pass infra cleanup #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zhiics |
jroesch
reviewed
Jun 12, 2019
| def __init__(self, name, opt_level, required=None): | ||
| self.__init_handle_by_constructor__(_transform.PassInfo, name, opt_level, | ||
| required) | ||
| def __init__(self, opt_level, name, required=None): |
There was a problem hiding this comment.
Why should we put opt_level first? I don't even think most passes should be on a standard opt-level, we end up in the current system we have where people arbitrarily assign pass numbers to passes and when passes are non-robust we just bump them to a higher pass number.
There was a problem hiding this comment.
We should focus on names and enabling passes by name in most cases imo.
There was a problem hiding this comment.
I made the change just to be consistent with the rest of the positional argument, we can debate whether it is a good idea to put name or opt_level first. I am fine either way
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #3319