Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][VTA] PkgConfig cause crash in PYNQ board due to link library #3257

Merged
merged 2 commits into from
Jun 1, 2019
Merged

Conversation

huajsj
Copy link
Contributor

@huajsj huajsj commented May 30, 2019

not exist.

Symptom:
When run vta_get_started.py with pynq board, host crash and
complain "cannot find -lsds_lib" and "cannot find -l:libdma.so"

Reproduce:
At pynq board, delete the ./build/vta_config.json, then run rpc
server.
In host machine run vta_get_started.py, issue would reproduce.

Analysis:
This issue caused by 'PkgConfig' function still using pynq2.1
library which not exist in pynq2.3 anymore, when a "reconfig_runtime"
logic of rpc_server.py get triggered , the compile would failed due to
link library not exist.

Solution:
change the link library to libcma.so.

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@huajsj
Copy link
Contributor Author

huajsj commented May 30, 2019

@tmoreau89 could you help to review this patch?

Thanks
Hua

@tmoreau89
Copy link
Contributor

Thanks for fixing Pynq support for 2.3 image. If we do release 2.3 support, we'll need to update the documentation. Can you also update the doc in the PR? You can find it under tvm/docs/vta/install.md

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the doc to reflect the 2.3 pynq image migration

@huajsj
Copy link
Contributor Author

huajsj commented May 30, 2019

@tmoreau89 , the content of vta/install.md already reflect pynq 2.3, and a former PR #1945 did such change, please kindly let me know if you need any other change.

@tmoreau89
Copy link
Contributor

Ah good point, what I meant was that the current version of VTA is at 2.4. I believe that there isn't a difference between these two versions in terms of library paths. Would you mind double checking that it works on 2.4, and update the doc accordingly since this is the image that's available at the moment?

@huajsj
Copy link
Contributor Author

huajsj commented May 31, 2019

@tmoreau89 , thanks for the clarify, this patch not target for pynq 2.4 and just 2.3 issue fixed, about 2.4 support, how about we use different PR to address? I can work for this 2.4 support issue then use separate PR for doc and any other necessary fix, please kindly let me know how you think.

@tmoreau89
Copy link
Contributor

@huajsj since 2.4 is now the version that can be downloaded from the pynq.io website I believe it would be best to support that now. I believe that if you flash a new SD card, you should be able to get your branch to build - therefore if you could just verify that it works, and update the documentation, we can keep this PR as is.

@tmoreau89
Copy link
Contributor

in other words, no need for a new PR

huajsj added 2 commits May 31, 2019 13:33
not exist.

Symptom:
When run vta_get_started.py with pynq board, host crash and
complain "cannot find -lsds_lib" and "cannot find -l:libdma.so"

Reproduce:
At pynq board, delete the ./build/vta_config.json, then run rpc
server.
In host machine run vta_get_started.py, issue would reproduce.

Analysis:
This issue caused by 'PkgConfig' function  still using pynq2.1
library which not exist in pynq2.4 anymore, when a "reconfig_runtime"
logic of rpc_server.py get triggered , the compile would failed due to
link library not exist.

Solution:
change the link library to libcma.so.
Issue:
pynq 2.3 image not available anymore from pynq download page and pynq
2.4 is the current latest image which available in the said website, after
verification, currently VTA work good with pynq 2.4 image, hence update
related document from pynq 2.3 to 2.4.
@huajsj
Copy link
Contributor Author

huajsj commented Jun 1, 2019

@tmoreau89 , sure, get it, verification finished(build pass, vta_get_start.py success), current vta work good at PYNQ2.4, related documents already get updated from 2.3 into 2.4.

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmoreau89 tmoreau89 merged commit f6acf2e into apache:master Jun 1, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Jun 26, 2019
…apache#3257)

* [Bugfix][VTA] PkgConfig cause crash in PYNQ board due to link library
not exist.

Symptom:
When run vta_get_started.py with pynq board, host crash and
complain "cannot find -lsds_lib" and "cannot find -l:libdma.so"

Reproduce:
At pynq board, delete the ./build/vta_config.json, then run rpc
server.
In host machine run vta_get_started.py, issue would reproduce.

Analysis:
This issue caused by 'PkgConfig' function  still using pynq2.1
library which not exist in pynq2.4 anymore, when a "reconfig_runtime"
logic of rpc_server.py get triggered , the compile would failed due to
link library not exist.

Solution:
change the link library to libcma.so.

* [Document Change][VTA] Change pynq version from 2.3 into 2.4.

Issue:
pynq 2.3 image not available anymore from pynq download page and pynq
2.4 is the current latest image which available in the said website, after
verification, currently VTA work good with pynq 2.4 image, hence update
related document from pynq 2.3 to 2.4.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Jun 27, 2019
…apache#3257)

* [Bugfix][VTA] PkgConfig cause crash in PYNQ board due to link library
not exist.

Symptom:
When run vta_get_started.py with pynq board, host crash and
complain "cannot find -lsds_lib" and "cannot find -l:libdma.so"

Reproduce:
At pynq board, delete the ./build/vta_config.json, then run rpc
server.
In host machine run vta_get_started.py, issue would reproduce.

Analysis:
This issue caused by 'PkgConfig' function  still using pynq2.1
library which not exist in pynq2.4 anymore, when a "reconfig_runtime"
logic of rpc_server.py get triggered , the compile would failed due to
link library not exist.

Solution:
change the link library to libcma.so.

* [Document Change][VTA] Change pynq version from 2.3 into 2.4.

Issue:
pynq 2.3 image not available anymore from pynq download page and pynq
2.4 is the current latest image which available in the said website, after
verification, currently VTA work good with pynq 2.4 image, hence update
related document from pynq 2.3 to 2.4.
tqchen pushed a commit to tqchen/tvm that referenced this pull request Mar 29, 2020
…apache#3257)

* [Bugfix][VTA] PkgConfig cause crash in PYNQ board due to link library
not exist.

Symptom:
When run vta_get_started.py with pynq board, host crash and
complain "cannot find -lsds_lib" and "cannot find -l:libdma.so"

Reproduce:
At pynq board, delete the ./build/vta_config.json, then run rpc
server.
In host machine run vta_get_started.py, issue would reproduce.

Analysis:
This issue caused by 'PkgConfig' function  still using pynq2.1
library which not exist in pynq2.4 anymore, when a "reconfig_runtime"
logic of rpc_server.py get triggered , the compile would failed due to
link library not exist.

Solution:
change the link library to libcma.so.

* [Document Change][VTA] Change pynq version from 2.3 into 2.4.

Issue:
pynq 2.3 image not available anymore from pynq download page and pynq
2.4 is the current latest image which available in the said website, after
verification, currently VTA work good with pynq 2.4 image, hence update
related document from pynq 2.3 to 2.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants