-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[relay][pass manager] Open transform namespace #3226
Conversation
I am also going to change |
We don’t want Sequential and sequential, both of which are duplicated. Consider merge as Sequential(use constructor in py and possibly the same function name in cxx). Let us double check the desirable API. Specially, we want to have something like Pass FoldConstant(); |
A quick way to check is to see if we can reproduce the example shown in the RFC |
I think we should be able to execute that example using the current Sequential, like https://github.com/dmlc/tvm/blob/master/tests/python/relay/test_pass_manager.py#L357 The problem is that we need to finish pass registration, meaning we need to have But I currently haven't used |
include/tvm/relay/transform.h
Outdated
* perform a host of optimizations with a given optimization level and disabled | ||
* passes. | ||
*/ | ||
class SequentialNode : public PassNode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
declare node, but hide the implementation inside. (User don't need to see SequentialNode, they only need to see Sequantial)
Merge this in for now. Thanks, @zhiics. I will propose a few improves in a follow-up PR |
This PR is the first item of #3202
Now we open the
transform
namespace by adding transform.h and transform.py. Currently, pass manager related code is moved to these two files. The ir_pass related code is left in the original place. They will be moved once we finish porting.cc @jroesch @tqchen @MarisaKirisame @wweic @slyubomirsky