[NODE] Macro to define NodeRef methods, constructor style example #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
reviewed
May 23, 2019
|
|
||
| /*! \brief Macro to make it easy to define node ref type given node */ | ||
| #define TVM_DEFINE_NODE_REF(TypeName, NodeName) \ |
There was a problem hiding this comment.
good point, I think we will move to avoid use TVM_DEFINE_NODE_REF and directly use class declarations plus TVM_DEFINE_NODE_REF_METHODS.
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates what can be done as discussed in RFC #3223 . We will need to wait to see discussions in the RFC before merging this.