[BugFix][VTA] Fix vta_conv2d crash issue after change vta_config.json #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tqchen @tmoreau89 could you help to review this patch? Thanks |
tmoreau89
reviewed
May 24, 2019
tmoreau89
requested changes
May 24, 2019
… configuration. Issue: Once change LOG_BLOCK_IN or LOG_BLOCK_OUT into > 4 value, when run vta “Simple Matrix Multiply” or load vta, vta would crash at vta_conv2d.py. Analysis: This issue caused by resnet18 logic of vta_conv2d.py which have in_filter minmum size that is 16. > 4 value would cause such in_filter check failed then make xfer_size be empty and find_schedules function return a empty list finally cause crash. Solution: add the empty list check.
|
@tmoreau89 , the change request already addressed, please kindly let me know if you have any other comments. |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
… configuration. (apache#3213) Issue: Once change LOG_BLOCK_IN or LOG_BLOCK_OUT into > 4 value, when run vta “Simple Matrix Multiply” or load vta, vta would crash at vta_conv2d.py. Analysis: This issue caused by resnet18 logic of vta_conv2d.py which have in_filter minmum size that is 16. > 4 value would cause such in_filter check failed then make xfer_size be empty and find_schedules function return a empty list finally cause crash. Solution: add the empty list check.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
… configuration. (apache#3213) Issue: Once change LOG_BLOCK_IN or LOG_BLOCK_OUT into > 4 value, when run vta “Simple Matrix Multiply” or load vta, vta would crash at vta_conv2d.py. Analysis: This issue caused by resnet18 logic of vta_conv2d.py which have in_filter minmum size that is 16. > 4 value would cause such in_filter check failed then make xfer_size be empty and find_schedules function return a empty list finally cause crash. Solution: add the empty list check.
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Mar 29, 2020
… configuration. (apache#3213) Issue: Once change LOG_BLOCK_IN or LOG_BLOCK_OUT into > 4 value, when run vta “Simple Matrix Multiply” or load vta, vta would crash at vta_conv2d.py. Analysis: This issue caused by resnet18 logic of vta_conv2d.py which have in_filter minmum size that is 16. > 4 value would cause such in_filter check failed then make xfer_size be empty and find_schedules function return a empty list finally cause crash. Solution: add the empty list check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configuration.
Issue:
Once change LOG_BLOCK_IN or LOG_BLOCK_OUT into > 4 value, when run vta
“Simple Matrix Multiply” or load vta, vta would crash at vta_conv2d.py.
Analysis:
This issue caused by resnet18 logic of vta_conv2d.py which have
in_filter minmum size that is 16. > 4 value would cause such in_filter
check failed then make xfer_size be empty and find_schedules function
return a empty list finally cause crash.
Solution:
add the empty list check.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.