Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] add Neg and ClipByValue in tf frontend #3211

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

yongwww
Copy link
Member

@yongwww yongwww commented May 20, 2019

Add Neg and ClipByValue op in TF frontend.

@yidawang @srkreddy1238 @zhiics @yzhliu @wweic

Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongwww yongwww force-pushed the tf-control-flow branch from 2db1f06 to 924245a Compare May 21, 2019 18:33
@yongwww yongwww changed the title [Relay] add ClipByValue in tf frontend [Relay] add Neg and ClipByValue in tf frontend May 21, 2019
@@ -1708,6 +1716,7 @@ def test_placeholder():
test_forward_pow_exp()
test_forward_sign()
test_forward_log()
test_forward_negative()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add a test case for ClipByValue too.

@tqchen tqchen assigned tqchen and srkreddy1238 and unassigned tqchen May 24, 2019
@tqchen
Copy link
Member

tqchen commented May 24, 2019

@srkreddy1238 please manage the PR

@yongwww yongwww force-pushed the tf-control-flow branch from 0473f14 to 7fffd7d Compare May 30, 2019 19:04
@yongwww
Copy link
Member Author

yongwww commented May 30, 2019

@srkreddy1238 all test cases are added, pls take another look

@tqchen tqchen merged commit b67afcd into apache:master Jun 12, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Jun 26, 2019
@yongwww yongwww deleted the tf-control-flow branch December 8, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants