Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Relay] [NNVM] [Frontend] implement MaxPool-8 and MaxPool-10 #3114

Merged
merged 7 commits into from
May 22, 2019

Conversation

higumachan
Copy link
Contributor

I implement new version MaxPooling Operator parameters loader.

@higumachan higumachan changed the title [Relay] [NNVM] [Frontend] implement MaxPool-8 and MaxPool-10 [WIP] [Relay] [NNVM] [Frontend] implement MaxPool-8 and MaxPool-10 Apr 28, 2019
@jroesch jroesch requested a review from zhreshold May 7, 2019 23:31
Copy link
Member

@zhreshold zhreshold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@tqchen
Copy link
Member

tqchen commented May 16, 2019

@higumachan please fix the lint error

@tqchen tqchen added the status: need update need update based on feedbacks label May 16, 2019
@tqchen tqchen merged commit 3272e6c into apache:master May 22, 2019
@tqchen tqchen added status: accepted and removed status: need update need update based on feedbacks labels May 22, 2019
@tqchen
Copy link
Member

tqchen commented May 22, 2019

Thanks, @higumachan @zhreshold , this is now merged

@higumachan higumachan deleted the feature/onnx_maxpooling_v8_and_v10 branch May 23, 2019 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants