Implement relay nn.bias_add compute in C++ #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
reviewed
Apr 15, 2019
antinucleon
reviewed
Apr 16, 2019
antinucleon
reviewed
Apr 16, 2019
added 2 commits
April 15, 2019 21:22
|
Comments addressed. |
Laurawly
approved these changes
Apr 17, 2019
larroy
pushed a commit
to larroy/tvm
that referenced
this pull request
Apr 19, 2019
* Implement nn.bias_add compute in C++ * Address comments * Remove unnecessary check
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
* Implement nn.bias_add compute in C++ * Address comments * Remove unnecessary check
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
* Implement nn.bias_add compute in C++ * Address comments * Remove unnecessary check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay
nn.bias_addnow has a compute implementation in Python, which is inconvenient for C++ flow given many of the Relay nodes already are implemented in C++. This PR ports the compute from Python to C++.