[FRONTEND][TFLITE] Add FULLY_CONNECTED op into tflite frontend, support Inception V4 #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songqun
changed the title
songqun
changed the title
jroesch
reviewed
Apr 15, 2019
| @@ -512,6 +563,21 @@ def test_forward_inception_v3_net(): | |||
| tvm.testing.assert_allclose(np.squeeze(tvm_output[0]), np.squeeze(tflite_output[0]), | |||
| rtol=1e-5, atol=1e-5) | |||
|
|
|||
| def test_forward_inception_v4_net(): | |||
| '''test inception v4 tflite model''' | |||
There was a problem hiding this comment.
Suggested change
| '''test inception v4 tflite model''' | |
| """Test the Inception v4 TF Lite model.""" |
There was a problem hiding this comment.
Do I need to fix the comment style for all other end-to-end tests such as """Test the Mobilenet V1 TF Lite model.""" instead of '''test mobilenet v1 tflite model'''?
|
Can you just fix the message and then I will merge 😄 |
|
ping @jroesch |
|
@jroesch Could you help me merge the branch? |
jroesch
approved these changes
May 1, 2019
|
Sorry about the slow response, been very busy :) |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
…rt Inception V4 (apache#3019) * Add FULLY_CONNECTED op into tflite frontend, support Inception V4 * Fix comment style in TF Lite tests.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
…rt Inception V4 (apache#3019) * Add FULLY_CONNECTED op into tflite frontend, support Inception V4 * Fix comment style in TF Lite tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add FULLY_CONNECTED op into tflite frontend to support Inception V4.
see https://discuss.tvm.ai/t/tflite-fully-connected/2192