Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix caffe2 nnvm frontend #2996

Merged
merged 1 commit into from
Apr 13, 2019
Merged

[Bugfix] Fix caffe2 nnvm frontend #2996

merged 1 commit into from
Apr 13, 2019

Conversation

hlu1
Copy link
Contributor

@hlu1 hlu1 commented Apr 9, 2019

The caffe2 nnvm frontend got broken by #2828

@hlu1
Copy link
Contributor Author

hlu1 commented Apr 12, 2019

cc @KoinFlyp, @yidawang, and @tqchen

markrogersjr
markrogersjr reviewed Apr 12, 2019
View reviewed changes
Copy link
Contributor

@markrogersjr markrogersjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering how this slipped past the integration tests. Perhaps we should add one for Caffe2?

@tqchen tqchen merged commit fefbb00 into apache:master Apr 13, 2019
@hlu1
Copy link
Contributor Author

hlu1 commented Apr 13, 2019 •
edited
Loading

@KoinFlyp, it looks that the nnvm caffe2 frontend is not included in the CI, only the relay caffe2 frontend is included: https://github.com/dmlc/tvm/blob/master/tests/scripts/task_python_frontend.sh#L75
Added in #3018

@hlu1 hlu1 deleted the fix_c2 branch April 17, 2019 06:51
wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019
@hlu1
[Bugfix] Fix caffe2 nnvm frontend (apache#2996)
5b5e0fb
wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019
@hlu1 @wweic
[Bugfix] Fix caffe2 nnvm frontend (apache#2996)
e7d2ceb
@yzhliu yzhliu mentioned this pull request Nov 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markrogersjr markrogersjr markrogersjr left review comments

@yidawang yidawang yidawang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlu1 @markrogersjr @yidawang @tqchen