[tvm4j] provide error msg for failure function call #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Apr 5, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 7, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 7, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 8, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 10, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve the problem that people always see things like "Do NOT know how to handle return type code 28672" in tvm4j. If function call fails, it should return immediately so that the wrapper can get the last error message, otherwise it would fail in
tvmRetValueToJava. @tqchen