Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay][Frontend] Support tf.where #2936

Merged
merged 2 commits into from
Apr 3, 2019
Merged

[Relay][Frontend] Support tf.where #2936

merged 2 commits into from
Apr 3, 2019

Conversation

yongwww
Copy link
Member

@yongwww yongwww commented Mar 31, 2019

srkreddy1238
srkreddy1238 requested changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yongwww .
Good to go with minor comments.

tests/python/frontend/tensorflow/test_forward.py Outdated Show resolved Hide resolved
tests/python/frontend/tensorflow/test_forward.py Show resolved Hide resolved
@yzhliu yzhliu added the status: need update need update based on feedbacks label Apr 2, 2019
@yongwww
Copy link
Member Author

yongwww commented Apr 3, 2019

@srkreddy1238 incorporated comments. Pls take another look.

@srkreddy1238 srkreddy1238 merged commit eb82e7b into apache:master Apr 3, 2019
@srkreddy1238
Copy link
Contributor

Thanks @zhiics @yongwww @jroesch . This is now merged.

wweic pushed a commit to wweic/tvm that referenced this pull request Apr 7, 2019
@yongwww @wweic
[Relay][Frontend] Support tf.where (apache#2936)
1755c26 
* [Relay][Frontend] Support tf.where

* fix comments
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 7, 2019
@yongwww @wweic
[Relay][Frontend] Support tf.where (apache#2936)
4565574 
* [Relay][Frontend] Support tf.where

* fix comments
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 8, 2019
@yongwww @wweic
[Relay][Frontend] Support tf.where (apache#2936)
bb41ccb 
* [Relay][Frontend] Support tf.where

* fix comments
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 10, 2019
@yongwww @wweic
[Relay][Frontend] Support tf.where (apache#2936)
d060856 
* [Relay][Frontend] Support tf.where

* fix comments
wweic pushed a commit to neo-ai/tvm that referenced this pull request Apr 11, 2019
@yongwww @wweic
[Relay][Frontend] Support tf.where (apache#2936)
244a533 
* [Relay][Frontend] Support tf.where

* fix comments
@tqchen tqchen mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srkreddy1238 srkreddy1238 srkreddy1238 approved these changes

@zhiics zhiics zhiics approved these changes

@jroesch jroesch jroesch approved these changes

@wweic wweic wweic approved these changes

Assignees
No one assigned
Labels
status: need update need update based on feedbacks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yongwww @srkreddy1238 @wweic @jroesch @zhiics @yzhliu