[TVM][ARITH] Teach BoundDeduce to handle the case in which target var can appear in rhs of expression #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xqdan
reviewed
Mar 15, 2019
|
@xqdan @ZihengJiang the CI build was failing due to a testcase that's now been commented out. Can you please take another look? Thanks. |
ZihengJiang
approved these changes
Apr 26, 2019
|
thanks @derisavi , this is merged |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
… can appear in rhs of expression (apache#2795) * target variable can now appear in either lhs or rhs of the expression to be analyzed * removed extra spaces
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
… can appear in rhs of expression (apache#2795) * target variable can now appear in either lhs or rhs of the expression to be analyzed * removed extra spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ZihengJiang, @xqdan, and/or @sgrechanik-h Please review.
This fixes #2794
Added @tqchen for review in case he is available.
This is a simple change.