[Relay][TOPI] Gluncv SSD support on the GPU #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apivovarov
reviewed
Mar 12, 2019
kevinthesun
requested changes
Mar 12, 2019
|
Overall lgtm. One more thing is what is the situation of gpu related grammar sugars supporting in hybrid script? @were If possible we can migrate vision op to hybrid script implementation as well. |
Currently, I'm still experimenting with the hybrid script. There could still be some problems. But I'll communicate with @were during the process. |
Laurawly
force-pushed
the
dev
branch
6 times, most recently
from
83d1ab2 to
b66ff61
Compare
Laurawly
force-pushed
the
dev
branch
4 times, most recently
from
d6830a2 to
02855fa
Compare
liangfu
reviewed
Mar 18, 2019
Laurawly
force-pushed
the
dev
branch
4 times, most recently
from
a4789e8 to
a7b5d9e
Compare
|
LGTM. @Laurawly Can you open an issue to track the progress to migrate from ir_builder to hybrid script? |
kevinthesun
approved these changes
Apr 24, 2019
icemelon
requested changes
Apr 25, 2019
icemelon
requested changes
Apr 26, 2019
topi/python/topi/generic/vision.py
Outdated
| @@ -188,3 +188,20 @@ def schedule_proposal(outs): | |||
| The computation schedule for the op. | |||
| """ | |||
| return _default_schedule(outs, False) | |||
|
|
|||
| @tvm.target.generic_func | |||
| def schedule_argsort(outs): | |||
There was a problem hiding this comment.
move this function to topi/generic/sort.py
icemelon
approved these changes
Apr 27, 2019
docs/langref/relay_op.rst
Outdated
| @@ -164,6 +164,15 @@ This level enables additional math and transform operators. | |||
| tvm.relay.vision.yolo_reorg | |||
|
|
|||
|
|
|||
| **Level 6: Algorithm Operators** | |||
| ------------------- | |||
|
@Laurawly please act on @icemelon9 's remaining comment |
tqchen
added
status: need update
Comments addressed. |
icemelon
added
status: accepted
and removed
status: need update
|
Thanks everyone. This is now merged. |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
* ssd gluoncv gpu op updated * ssd gluoncv gpu op updated * tutorials and testes modified * tutorials and testes modified * fix lint * fix lint * address comment * multibox bug fixed * space line added * use less threads per block * use less threads per block * less threads per block for get valid count * less threads per block for get valid count * merge with master * Revert "less threads per block for get valid count" This reverts commit 08896cf. * Revert "less threads per block for get valid count" This reverts commit 08896cf. * typo fixed * elem length made to a variable * fix lint error * fix lint error * lint fixed * bug fixed * bug fixed * lint fixed * error fixed * error fixed * test ci * test ci * seperate argsort to be an independent op * seperate argsort to be an independent op * fix lint * fix lint * remove unsupported models * typo fixed * argsort added to realy * solve conflicts with master * fix lint * fix lint * test push * Revert "test push" This reverts commit 6db0088. * fix lint error * fix more lint * cpu test_sort udpated * debug ci * nms fixed * expose argsort to relay frontend * test ci * fix lint * sort register error fixed * fix nnvm * nms type fixed * adaptive pooling added to relay * Revert "adaptive pooling added to relay" This reverts commit 1119f1f. * fix lint * expose argsort op * fix lint * fix lint * fix lint * sort test updated * sort bug fixed * nnvm error fixed * fix argsort default data type returned to be float insteaf of int * fix lint * fix lint * test fixed * fix valid count * fix titanx bug * tutorial add both targets * titanx error fixed * try to fix CI old gpu error * try to solve CI GPU error * get_valid_count added * reverse get_valid_count * get valid count optimized * address comments * fix ci error * remove unessesary block sync * add back one sync * address comments * address more comments * more comments * move sort to be indepent algorithm * typo fixed * more typos * comments addressed * doc updated * fix pylint * address final comments * apache license added
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
* ssd gluoncv gpu op updated * ssd gluoncv gpu op updated * tutorials and testes modified * tutorials and testes modified * fix lint * fix lint * address comment * multibox bug fixed * space line added * use less threads per block * use less threads per block * less threads per block for get valid count * less threads per block for get valid count * merge with master * Revert "less threads per block for get valid count" This reverts commit 08896cf. * Revert "less threads per block for get valid count" This reverts commit 08896cf. * typo fixed * elem length made to a variable * fix lint error * fix lint error * lint fixed * bug fixed * bug fixed * lint fixed * error fixed * error fixed * test ci * test ci * seperate argsort to be an independent op * seperate argsort to be an independent op * fix lint * fix lint * remove unsupported models * typo fixed * argsort added to realy * solve conflicts with master * fix lint * fix lint * test push * Revert "test push" This reverts commit 6db0088. * fix lint error * fix more lint * cpu test_sort udpated * debug ci * nms fixed * expose argsort to relay frontend * test ci * fix lint * sort register error fixed * fix nnvm * nms type fixed * adaptive pooling added to relay * Revert "adaptive pooling added to relay" This reverts commit 1119f1f. * fix lint * expose argsort op * fix lint * fix lint * fix lint * sort test updated * sort bug fixed * nnvm error fixed * fix argsort default data type returned to be float insteaf of int * fix lint * fix lint * test fixed * fix valid count * fix titanx bug * tutorial add both targets * titanx error fixed * try to fix CI old gpu error * try to solve CI GPU error * get_valid_count added * reverse get_valid_count * get valid count optimized * address comments * fix ci error * remove unessesary block sync * add back one sync * address comments * address more comments * more comments * move sort to be indepent algorithm * typo fixed * more typos * comments addressed * doc updated * fix pylint * address final comments * apache license added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #2353, applying apis accordingly, support glunocv ssd models on the GPU.
Also exposed
coord_start,score_indexvariables to frontend for supporting more object detection networks. Addedargsortas an operator, support both CPU and GPU. Adaptive pooling op exposed.