Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][caffe2] Fix caffe2 relay frontend #2733

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

hlu1
Copy link
Contributor

@hlu1 hlu1 commented Mar 5, 2019

Fixed a few bugs in the caffe2 relay frontend.

@jroesch
Copy link
Member

jroesch commented Mar 5, 2019

Is it possible to add a test for this case?

@yzhliu yzhliu added the status: need update need update based on feedbacks label Mar 7, 2019
@tqchen tqchen added the status: need test case need test cases to cover the change label Mar 9, 2019
@tqchen
Copy link
Member

tqchen commented Mar 9, 2019

ping @hlu1 can you act based on comments?

@hlu1 hlu1 force-pushed the fix_caffe2_frontend branch from 40b6304 to 133b843 Compare March 11, 2019 08:32
@hlu1
Copy link
Contributor Author

hlu1 commented Mar 11, 2019

Added test cases for elementwise Add (with and without broadcast) and NormalizePlanarYUV

@tqchen tqchen added status: need review and removed status: need test case need test cases to cover the change labels Mar 11, 2019
@tqchen tqchen merged commit 6c60b8d into apache:master Mar 14, 2019
@tqchen tqchen added status: accepted and removed status: need review status: need update need update based on feedbacks labels Mar 14, 2019
@tqchen
Copy link
Member

tqchen commented Mar 14, 2019

Thanks @hlu1 , this is now merged

wweic pushed a commit to wweic/tvm that referenced this pull request Mar 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 20, 2019
@hlu1 hlu1 deleted the fix_caffe2_frontend branch April 17, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants