[Relay][TOPI][OP] intel_graphics conv2d alterlayout support relay, added stack op #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laurawly
changed the title
yzhliu
reviewed
Mar 5, 2019
| if F == sym: | ||
| out = F.contrib.conv2d_NCHWc(*copy_inputs, **new_attrs) | ||
| else: | ||
| out = F.nn.contrib_conv2d_nchwc(*copy_inputs, **new_attrs) |
There was a problem hiding this comment.
does it work? Conv2dAttr contains layout in nnvm while in Relay the name is data_layout though
There was a problem hiding this comment.
@yzhliu It seems working for me. relay.nn.contrib_conv2d_nchwc
There was a problem hiding this comment.
oh yes, because it is copy, relay copies to relay, nnvm copies to nnvm.
yzhliu
approved these changes
Mar 6, 2019
|
Thanks @Laurawly |
bwasti
pushed a commit
to facebookexperimental/tvm
that referenced
this pull request
Mar 6, 2019
…ded stack op (apache#2729) * add stack op frontend * concate moved * topi stack added * stack added * fix stack bugs and tested * conv2d alterlayout udpated for relay * fix pylint * fix cmake warnings * cmake warnings fixed
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
…ded stack op (apache#2729) * add stack op frontend * concate moved * topi stack added * stack added * fix stack bugs and tested * conv2d alterlayout udpated for relay * fix pylint * fix cmake warnings * cmake warnings fixed
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
…ded stack op (apache#2729) * add stack op frontend * concate moved * topi stack added * stack added * fix stack bugs and tested * conv2d alterlayout udpated for relay * fix pylint * fix cmake warnings * cmake warnings fixed
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
…ded stack op (apache#2729) * add stack op frontend * concate moved * topi stack added * stack added * fix stack bugs and tested * conv2d alterlayout udpated for relay * fix pylint * fix cmake warnings * cmake warnings fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also concatenate op moved compute to align with other ops.