Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PassManager] Implement pass manager tracing API #4782

Merged
merged 7 commits into from
Jan 28, 2020
Merged

[PassManager] Implement pass manager tracing API #4782

merged 7 commits into from
Jan 28, 2020

Conversation

jroesch
Copy link
Member

@jroesch jroesch commented Jan 28, 2020

I am working on some pass infrastructure for TVM and needed the previously discussed tracing feature

@jroesch jroesch requested a review from zhiics January 28, 2020 00:42
@jroesch
Copy link
Member Author

jroesch commented Jan 28, 2020

cc @zhiics @tmoreau89

tmoreau89
tmoreau89 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; can you add an example on how to use the tracer to print the Relay IR between every pass (one example where it prints before, and one example where it prints after)

@jroesch
Copy link
Member Author

jroesch commented Jan 28, 2020

@tmoreau89 I added to the pass docs with an example.

@zhiics zhiics merged commit 9c383f6 into apache:master Jan 28, 2020
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
@jroesch @alexwong
[PassManager] Implement pass manager tracing API (apache#4782)
111bf28 
* Implement pass tracing API

* Set is_before correctly

* Add docs for trace function

* Fix lint

* Remove PDB

* Ensure trace_func is set before calling

* Fix conditional
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
@jroesch @alexwong
[PassManager] Implement pass manager tracing API (apache#4782)
652b21c 
* Implement pass tracing API

* Set is_before correctly

* Add docs for trace function

* Fix lint

* Remove PDB

* Ensure trace_func is set before calling

* Fix conditional
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
@jroesch @zhiics
[PassManager] Implement pass manager tracing API (apache#4782)
4bebfad 
* Implement pass tracing API

* Set is_before correctly

* Add docs for trace function

* Fix lint

* Remove PDB

* Ensure trace_func is set before calling

* Fix conditional
@ZihengJiang ZihengJiang mentioned this pull request Sep 17, 2020
Closed
@jroesch jroesch deleted the pass_callback_via_cx branch February 4, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmoreau89 tmoreau89 tmoreau89 approved these changes

@zhiics zhiics zhiics approved these changes

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jroesch @tqchen @zhiics @tmoreau89