Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay][Frontend][TFlite] Add parser support for relational ops #4695

Merged
merged 1 commit into from
Jan 30, 2020
Merged

[Relay][Frontend][TFlite] Add parser support for relational ops #4695

merged 1 commit into from
Jan 30, 2020

Conversation

inadob
Copy link
Contributor

@inadob inadob commented Jan 13, 2020

  • Add support for: greater_equal, less, less_equal, equal, not_equal
  • Add tests for the elemwise relational ops

@inadob
Copy link
Contributor Author

inadob commented Jan 13, 2020

@anijain2305 @FrozenGene, can you please review this PR

@FrozenGene FrozenGene self-assigned this Jan 19, 2020
@FrozenGene FrozenGene added status: need update need update based on feedbacks and removed status: need review labels Jan 19, 2020
@inadob inadob requested a review from FrozenGene January 21, 2020 09:40
wyc-ruiker
wyc-ruiker approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@wyc-ruiker wyc-ruiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@inadob inadob requested a review from FrozenGene January 29, 2020 12:32
FrozenGene
FrozenGene requested changes Jan 29, 2020
View reviewed changes
python/tvm/relay/frontend/tflite.py Outdated Show resolved Hide resolved
tests/python/frontend/tflite/test_forward.py Outdated Show resolved Hide resolved
@inadob
[Relay][Frontend][TFlite] Add add parser support for relational ops
3bac206 
Add support for: greater_equal, less, less_equal, equal, not_equal
Add tests for the elemwise relational ops
@FrozenGene FrozenGene merged commit 6914963 into apache:master Jan 30, 2020
@FrozenGene FrozenGene added status: accepted and removed status: need update need update based on feedbacks labels Jan 30, 2020
@FrozenGene
Copy link
Member

Thanks @inadob @wyc-ruiker This is merged now.

alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
@inadob @alexwong
[Relay][Frontend][TFlite] Add add parser support for relational ops (a…
d146b86 
…pache#4695)

Add support for: greater_equal, less, less_equal, equal, not_equal
Add tests for the elemwise relational ops
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
@inadob @alexwong
[Relay][Frontend][TFlite] Add add parser support for relational ops (a…
ee40d77 
…pache#4695)

Add support for: greater_equal, less, less_equal, equal, not_equal
Add tests for the elemwise relational ops
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
@inadob @zhiics
[Relay][Frontend][TFlite] Add add parser support for relational ops (a…
839fa9a 
…pache#4695)

Add support for: greater_equal, less, less_equal, equal, not_equal
Add tests for the elemwise relational ops
@ZihengJiang ZihengJiang mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyc-ruiker wyc-ruiker wyc-ruiker approved these changes

@FrozenGene FrozenGene FrozenGene approved these changes

Assignees

@FrozenGene FrozenGene

Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inadob @FrozenGene @wyc-ruiker @tqchen