Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tutorial][benchmark] nnvm -> relay #4368

Merged
merged 3 commits into from
Nov 19, 2019
Merged

[tutorial][benchmark] nnvm -> relay #4368

merged 3 commits into from
Nov 19, 2019

Conversation

yzhliu
Copy link
Member

@yzhliu yzhliu commented Nov 18, 2019

@masahi
Copy link
Member

masahi commented Nov 18, 2019

Shouldn't we update get_network() too?

@yzhliu
Copy link
Member Author

yzhliu commented Nov 19, 2019

sorry I need to verify rpc once I get a device tomorrow.

elif name == 'mobilenet_v2':
net, params = nnvm.testing.mobilenet_v2.get_workload(batch_size=batch_size, dtype=dtype)
net, params = testing.mobilenet_v2.get_workload(batch_size=batch_size, dtype=dtype)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems testing.mobilenet_v2.get_workload doesn't exist, so delete it

elif "densenet" in name:
n_layer = int(name.split('-')[1])
net, params = nnvm.testing.densenet.get_workload(num_layers=n_layer, batch_size=batch_size, dtype=dtype)
net, params = testing.densenet.get_workload(num_layers=n_layer, batch_size=batch_size, dtype=dtype)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yzhliu
Copy link
Member Author

yzhliu commented Nov 19, 2019

@petrex could you also help to verify the arm results?

@petrex
Copy link
Contributor

petrex commented Nov 19, 2019

@yzhliu I can help verify the result on AMD GPU, is that what you are looking for? thx

@masahi
Copy link
Member

masahi commented Nov 19, 2019

I already tested it on AMD (also to verify recent AMDGPU codegen fix), @yzhliu maybe you mistook it for somebody else?

@yzhliu
Copy link
Member Author

yzhliu commented Nov 19, 2019

@masahi @petrex sorry typo - AMD gpu, as @petrex mentioned earlier. Thanks for verifying:)

@masahi masahi merged commit fbeac5e into apache:master Nov 19, 2019
@yzhliu yzhliu deleted the nnvm_relay branch November 19, 2019 21:57
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Nov 26, 2019
* [tutorial] nnvm -> relay

* use relay workload

* delete movbilenetv2 option
yongwww pushed a commit to neo-ai/tvm that referenced this pull request Nov 26, 2019
* [tutorial] nnvm -> relay

* use relay workload

* delete movbilenetv2 option
@xliucs
Copy link

xliucs commented Jan 24, 2020

@yzhliu Hi, I am having hard time to reproduce the results of mobile GPU. I am wondering did you test this PR w/ mobile gpu? Thanks!!!

@yzhliu
Copy link
Member Author

yzhliu commented Jan 24, 2020

not yet. did you run auto tvm tuning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants