Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Panic Handler Optional #145

Closed
ivila opened this issue Oct 24, 2024 · 3 comments
Closed

Make Panic Handler Optional #145

ivila opened this issue Oct 24, 2024 · 3 comments

Comments

@ivila
Copy link
Contributor

ivila commented Oct 24, 2024

In no-std branch, teaclave SDK define a panic handler, which stop ta developer from setting an custom one (for example, we would like to log the panic information before calling TEE_Panic).

I think we should add a feature flag to let developer choose if they really need to disable the default one, just like this issue: rust-osdev/uefi-rs: Make panic handler optional

@b49020
Copy link
Contributor

b49020 commented Oct 24, 2024

Looks reasonable to me, feel free to create corresponding PR.

@ivila
Copy link
Contributor Author

ivila commented Oct 25, 2024

@b49020 Thanks for your patience, a PR has already created.

@ivila
Copy link
Contributor Author

ivila commented Oct 28, 2024

Done

@ivila ivila closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants