Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[druid] Updating Druid refresh metadata tests #4887

Conversation

john-bodley
Copy link
Member

This PR updates the Druid tests for refreshing of the metadata in the following ways:

  • Removes the unnecessary enumerating of datasources as there's only one.
  • Adds a check that the column type also is updated during the refresh. Previously we only checked the updated metrics.

to: @GabeLoins

@john-bodley john-bodley force-pushed the john-bodley-refine-druid-refresh-tests branch from 1d9416b to 8219ea4 Compare April 27, 2018 21:26
@codecov-io
Copy link

Codecov Report

Merging #4887 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4887   +/-   ##
=======================================
  Coverage   77.13%   77.13%           
=======================================
  Files          44       44           
  Lines        8542     8542           
=======================================
  Hits         6589     6589           
  Misses       1953     1953

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510ae84...8219ea4. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM

@john-bodley john-bodley merged commit 440fb77 into apache:master May 4, 2018
@john-bodley john-bodley deleted the john-bodley-refine-druid-refresh-tests branch May 4, 2018 01:16
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants