[setup] Dropping 3.4 and adding 3.6 #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley-deprecate-py34
branch
8 times, most recently
from
b592b9c
to
9589f77
Compare
john-bodley
force-pushed
the
john-bodley-deprecate-py34
branch
from
9589f77
to
81ffd0d
Compare
Codecov Report
@@ Coverage Diff @@
## master #4835 +/- ##
=======================================
Coverage 72.36% 72.36%
=======================================
Files 208 208
Lines 15662 15662
Branches 1227 1227
=======================================
Hits 11334 11334
Misses 4325 4325
Partials 3 3
Continue to review full report at Codecov.
|
|
In support of knocking out python 3.4. One of our dependencies (tornadoweb) does not support python 3.4. LGTM |
|
LGTM |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* [setup] Dropping 3.4 and 3.6 * Update tox.ini * Update .travis.yml
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
* [setup] Dropping 3.4 and 3.6 * Update tox.ini * Update .travis.yml
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [setup] Dropping 3.4 and 3.6 * Update tox.ini * Update .travis.yml
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 0.21.0 Pandas has dropped support for Python 3.4 which is now causing problems with Travis CI. I speculate the issue is only now surfacing with the release of
pipversion10.0per this thread.It seems other applications are dropping support for Python 3.4 and I was wondering whether we should do the same (and adding Python 3.6 as a replacement) as opposed to having to write specific logic to handle different Pandas versions.
This PR also updated the Travis CI matrix to include both Python 2.7 and 3.6 which ensures that the
nosetestsrun in the Python version specified by Travis, and that bothflake8andpylintrun for all Python versions (previously these ran only for Python 2.7).to: @fabianmenges @mistercrunch
cc: @timifasubaa