Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with fresher screenshots #4825

Merged
merged 3 commits into from
Apr 14, 2018

Conversation

mistercrunch
Copy link
Member

See the README on my fork: https://github.com/mistercrunch/superset/tree/newreadme

We could re-introduce gifs too, but we should craft new ones.

@codecov-io
Copy link

Codecov Report

Merging #4825 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4825   +/-   ##
=======================================
  Coverage   72.36%   72.36%           
=======================================
  Files         208      208           
  Lines       15662    15662           
  Branches     1227     1227           
=======================================
  Hits        11334    11334           
  Misses       4325     4325           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8669874...6587789. Read the comment docs.

Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Choose from a wide array of visualizations" image look broken

@mistercrunch
Copy link
Member Author

@xrmx it's expected, since I'm adding the image as part of this PR.

@mistercrunch mistercrunch merged commit 23a3365 into apache:master Apr 14, 2018
@mistercrunch mistercrunch deleted the newreadme branch April 14, 2018 22:32
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* Improve screenshots in README.md

* Add border to images

* Add visualizations.png
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
* Improve screenshots in README.md

* Add border to images

* Add visualizations.png
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Improve screenshots in README.md

* Add border to images

* Add visualizations.png
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants